Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Improve xcm-simulator#3546

Closed
amarsinghcodes wants to merge 91 commits intoparitytech:masterfrom
amarsinghcodes:amar-more-simulator-tests
Closed

Improve xcm-simulator#3546
amarsinghcodes wants to merge 91 commits intoparitytech:masterfrom
amarsinghcodes:amar-more-simulator-tests

Conversation

@amarsinghcodes
Copy link
Copy Markdown
Contributor

@amarsinghcodes amarsinghcodes commented Aug 1, 2021

Adds tests from #3537 to xcm-simulator (except teleport_assets)

Also makes message processing asynchronous and pulls it out from the test externalities environment to allow for the processing of messages that go back to the origin chain. The previous implementation ran into borrowing issues in the underlying RefCells when sending messages back to the origin.
Messages are processed after the closure passed to test_ext.execute_with().

@amarsinghcodes amarsinghcodes marked this pull request as ready for review August 1, 2021 18:18
@amarsinghcodes
Copy link
Copy Markdown
Contributor Author

amarsinghcodes commented Aug 1, 2021

@apopiak ready for your review :)

@shaunxw thanks for writing the simulator, let me know if I can use it better

@amarsinghcodes
Copy link
Copy Markdown
Contributor Author

Just merged #2815 into this branch, it'll be easier to review this PR again once that PR is merged into master

@amarsinghcodes
Copy link
Copy Markdown
Contributor Author

Ah I keep getting wrecked by auto-merge 😬 I'll open a new one

@amarsinghcodes amarsinghcodes deleted the amar-more-simulator-tests branch August 10, 2021 20:52
@apopiak
Copy link
Copy Markdown
Contributor

apopiak commented Aug 11, 2021

superseded by #3618

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants